From 90501f13573d46bc3a361c3098d0e59c8ceccc93 Mon Sep 17 00:00:00 2001
From: Tnze <cjd001113@outlook.com>
Date: Sat, 1 Apr 2023 09:52:12 +0800
Subject: [PATCH] fix VarInt written bytes counting problem. And add some
 comments.

---
 net/packet/types.go | 18 ++++++++++++------
 1 file changed, 12 insertions(+), 6 deletions(-)

diff --git a/net/packet/types.go b/net/packet/types.go
index c58e690..61839ae 100644
--- a/net/packet/types.go
+++ b/net/packet/types.go
@@ -252,12 +252,14 @@ func (l *Long) ReadFrom(r io.Reader) (n int64, err error) {
 }
 
 func (v VarInt) WriteTo(w io.Writer) (n int64, err error) {
-	vi := make([]byte, MaxVarIntLen)
-	nn := v.WriteToBytes(vi)
-	_, err = w.Write(vi[:nn])
+	var vi [MaxVarIntLen]byte
+	nn := v.WriteToBytes(vi[:])
+	nn, err = w.Write(vi[:nn])
 	return int64(nn), err
 }
 
+// WriteToBytes encodes the VarInt into buf and returns the number of bytes written.
+// If the buffer is too small, WriteToBytes will panic.
 func (v VarInt) WriteToBytes(buf []byte) int {
 	num := uint32(v)
 	i := 0
@@ -297,6 +299,7 @@ func (v *VarInt) ReadFrom(r io.Reader) (n int64, err error) {
 	return
 }
 
+// Len returns the number of bytes required to encode the VarInt.
 func (v VarInt) Len() int {
 	switch {
 	case v < 0:
@@ -315,12 +318,14 @@ func (v VarInt) Len() int {
 }
 
 func (v VarLong) WriteTo(w io.Writer) (n int64, err error) {
-	vi := make([]byte, MaxVarLongLen)
-	nn := v.WriteToBytes(vi)
-	_, err = w.Write(vi[:nn])
+	var vi [MaxVarLongLen]byte
+	nn := v.WriteToBytes(vi[:])
+	nn, err = w.Write(vi[:nn])
 	return int64(nn), err
 }
 
+// WriteToBytes encodes the VarLong into buf and returns the number of bytes written.
+// If the buffer is too small, WriteToBytes will panic.
 func (v VarLong) WriteToBytes(buf []byte) int {
 	num := uint64(v)
 	i := 0
@@ -359,6 +364,7 @@ func (v *VarLong) ReadFrom(r io.Reader) (n int64, err error) {
 	return
 }
 
+// Len returns the number of bytes required to encode the VarLong.
 func (v VarLong) Len() int {
 	switch {
 	case v < 0: